Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom offset window: support grains smaller than base grain #1648

Closed
wants to merge 6 commits into from
Closed

Custom offset window: support grains smaller than base grain #1648

wants to merge 6 commits into from
+26,476 −26,377

Conversation

courtneyholcomb
Copy link
Contributor

@courtneyholcomb courtneyholcomb commented Jan 29, 2025 •
edited
Loading

  • ugh. still need the test data to work for the offset metric. adding a new metric is probably easier than updating the data again.

@cla-bot cla-bot bot added the cla:yes label Jan 29, 2025
@dbt-labs dbt-labs deleted a comment from github-actions bot Jan 29, 2025
@courtneyholcomb courtneyholcomb force-pushed the court/custom-offset8.75 branch from b1c125d to 5266f30 Compare January 30, 2025 20:48
@courtneyholcomb courtneyholcomb force-pushed the court/custom-offset8.75 branch 4 times, most recently from aa5e340 to 3279ff4 Compare February 1, 2025 00:27
@courtneyholcomb courtneyholcomb added the Reload Test Data in SQL Engines Should be run when test data changes label Feb 1, 2025
@github-actions github-actions bot removed the Reload Test Data in SQL Engines Should be run when test data changes label Feb 1, 2025
@courtneyholcomb courtneyholcomb force-pushed the court/custom-offset8.75 branch from 3279ff4 to 4c497d9 Compare February 1, 2025 00:51
@courtneyholcomb courtneyholcomb added the Reload Test Data in SQL Engines Should be run when test data changes label Feb 1, 2025
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Feb 1, 2025
@courtneyholcomb courtneyholcomb force-pushed the court/custom-offset8.75 branch from 49b87ef to b33d054 Compare February 1, 2025 00:56
@courtneyholcomb courtneyholcomb removed the Reload Test Data in SQL Engines Should be run when test data changes label Feb 1, 2025
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Feb 1, 2025
@courtneyholcomb courtneyholcomb added Reload Test Data in SQL Engines Should be run when test data changes and removed Reload Test Data in SQL Engines Should be run when test data changes labels Feb 1, 2025
@github-actions github-actions bot removed the Reload Test Data in SQL Engines Should be run when test data changes label Feb 1, 2025
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Feb 1, 2025
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Feb 1, 2025
@courtneyholcomb courtneyholcomb force-pushed the court/custom-offset8.75 branch from 6361223 to 64e9c69 Compare February 1, 2025 01:56
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Feb 1, 2025
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Feb 1, 2025
Base automatically changed from court/custom-offset8.5 to main February 4, 2025 20:52
@courtneyholcomb courtneyholcomb force-pushed the court/custom-offset8.75 branch from 64e9c69 to c1e9f7b Compare February 5, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@courtneyholcomb